Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1534974289
##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
List<Row> offsets = executeAndParse("--topic-partitions",
"topic1:0,topic2:1,topic(3|4):2,__.*:3");
- List<Row> expected = Arrays.asList(
- new Row("__consumer_offsets", 3, 0L),
+ ArrayList<Row> expected = new ArrayList<>(
+ Arrays.asList(
new Row("topic1", 0, 1L),
new Row("topic2", 1, 2L),
new Row("topic3", 2, 3L),
new Row("topic4", 2, 4L)
+ )
);
+ if (!cluster.isKRaftTest()) {
Review Comment:
Sure. I've created Consumer to subscribe and poll from the topic for this
test.
##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
List<Row> offsets = executeAndParse("--topic-partitions",
"topic1:0,topic2:1,topic(3|4):2,__.*:3");
- List<Row> expected = Arrays.asList(
- new Row("__consumer_offsets", 3, 0L),
+ ArrayList<Row> expected = new ArrayList<>(
+ Arrays.asList(
new Row("topic1", 0, 1L),
new Row("topic2", 1, 2L),
new Row("topic3", 2, 3L),
new Row("topic4", 2, 4L)
+ )
);
+ if (!cluster.isKRaftTest()) {
Review Comment:
Sure. I've created Consumer to subscribe and poll from the topic for this
test, followed by verifying the pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
