chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1533209761
##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
this.timestamp = timestamp;
}
+ @Override
+ public String toString() {
+ return "Row[name:" + name + ",partition:" + partition +
",timestamp:" + timestamp;
Review Comment:
Is it used for debugging?
##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -338,6 +348,10 @@ private void assertExitCodeIsOne(String... args) {
}
private List<Row> expectedOffsetsWithInternal() {
+ if (cluster.isKRaftTest()) {
Review Comment:
I prefer to make callers use `expectedTestTopicOffsets` instead of adding
if-else here.
##########
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##########
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
List<Row> offsets = executeAndParse("--topic-partitions",
"topic1:0,topic2:1,topic(3|4):2,__.*:3");
- List<Row> expected = Arrays.asList(
- new Row("__consumer_offsets", 3, 0L),
+ ArrayList<Row> expected = new ArrayList<>(
Review Comment:
It seems we can keep using `List<Row>`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
