lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1525452774
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -976,6 +974,10 @@ void maybeReconcile() {
}
revokeAndAssign(resolvedAssignment, assignedTopicIdPartitions,
revokedPartitions, addedPartitions);
+ }).whenComplete((__, error) -> {
+ if (error != null) {
+ log.error("Reconciliation failed.", error);
Review Comment:
Is there a reason why we want this log here? We already have the same but
inside the `revokeAndAssign`, when reconciliation completes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]