lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1525418611
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -2279,22 +2277,23 @@ private MembershipManagerImpl
mockJoinAndReceiveAssignment(boolean expectSubscri
return mockJoinAndReceiveAssignment(expectSubscriptionUpdated,
createAssignment(expectSubscriptionUpdated));
}
- private MembershipManagerImpl mockJoinAndReceiveAssignment(boolean
expectSubscriptionUpdated,
+ private MembershipManagerImpl mockJoinAndReceiveAssignment(boolean
triggerReconciliation,
Review Comment:
Agree with the renamed param, but could we update it also in the same
overloaded method above, just for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
