lianetm commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1472861675
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -552,8 +555,63 @@ public void
testDelayedReconciliationResultAppliedWhenTargetChangedWithMetadataU
// Pending assignment that was discovered in metadata should be ready
to reconcile in the
// next reconciliation loop.
- Set<TopicIdPartition> topic2Assignment =
topicIdPartitionsSet(topicId2, topic2, 1, 2);
- assertEquals(topic2Assignment,
membershipManager.assignmentReadyToReconcile());
+ Map<Uuid, SortedSet<Integer>> topic2Assignment =
topicIdPartitionsMap(topicId2, 1, 2);
+ assertEquals(topic2Assignment,
membershipManager.topicPartitionsAwaitingReconciliation());
+ }
+
+ // Tests the case where topic metadata is not available at the time of the
assignment,
+ // but is made available later.
+ @Test
+ public void testDelayedMetadataUsedToCompleteAssignment() {
Review Comment:
Maybe this would be similar to what we cover in
`testUnresolvedTargetAssignmentIsReconciledWhenMetadataReceived`? Not exactly a
second reconciliation, but it tests that unresolved assignments are reconciled
when the metadata is received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
