lianetm commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1470081608
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -997,11 +985,13 @@ void markReconciliationCompleted() {
* </li>
* </ol>
*/
- private void resolveMetadataForUnresolvedAssignment() {
- assignmentReadyToReconcile.clear();
+ private SortedSet<TopicIdPartition> resolveMetadataForTargetAssignment() {
+ final SortedSet<TopicIdPartition> assignmentReadyToReconcile = new
TreeSet<>(TOPIC_ID_PARTITION_COMPARATOR);
+ final HashMap<Uuid, SortedSet<Integer>> unresolved = new
HashMap<>(currentTargetAssignment);
+
// Try to resolve topic names from metadata cache or subscription
cache, and move
// assignments from the "unresolved" collection, to the
"readyToReconcile" one.
Review Comment:
Dropping it sounds good to me, agree with your what vs why view on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
