cmccabe commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1471687028
##########
server-common/src/test/java/org/apache/kafka/common/DirectoryIdTest.java:
##########
@@ -67,18 +68,23 @@ void testCreateAssignmentMap() {
@Test
void testIsOnline() {
+ // Given
List<Uuid> sortedDirs = Arrays.asList(
Uuid.fromString("imQKg2cXTVe8OUFNa3R9bg"),
Uuid.fromString("Mwy5wxTDQxmsZwGzjsaX7w"),
Uuid.fromString("s8rHMluuSDCnxt3FmKwiyw")
);
sortedDirs.sort(Uuid::compareTo);
+ List<Uuid> emptySortedDirs = Collections.emptyList();
Review Comment:
Since this is a critical fix, I'm not going to hold it up for this comment.
But in the future, it would be better to put separate test cases in separate
test functions, rather than creating long tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
