showuon commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470823280
##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -244,6 +244,19 @@ class BrokerLifecycleManager(
eventQueue.append(new OfflineDirEvent(directory))
}
+ def handleKraftJBODMetadataVersionUpdate(): Unit = {
+ eventQueue.append(new KraftJBODMetadataVersionUpdateEvent())
+ }
+
+ private class KraftJBODMetadataVersionUpdateEvent extends EventQueue.Event {
+ override def run(): Unit = {
+ if (!isZkBroker) {
+ registered = false
+ scheduleNextCommunicationImmediately()
Review Comment:
I was thinking if it could cause the heartbeat timeout because we won't send
heartbeat when registered is false. But the brokerRegistration will also update
the lastContactNs in BrokerHeartbeatManager, so we're good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
