philipnee commented on code in PR #15228:
URL: https://github.com/apache/kafka/pull/15228#discussion_r1457941137
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -379,6 +379,7 @@ public Optional<AbstractRequest.Builder<?>> createRequest()
{
lock.readLock().unlock();
}
+ log.debug("Creating telemetry request. Telemetry state: {}",
localState);
Review Comment:
it would be useful to know the type of the request client is sending: either
it is a subscriptionRequest or push request. I guess we can derive it from the
current state, but state is rather an internal thing so that the person looking
at it might not know what it means. my suggestion is to be explicit about "we
are sending a push request" or "we are sending a subscription request".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
