apoorvmittal10 commented on code in PR #15228:
URL: https://github.com/apache/kafka/pull/15228#discussion_r1457875345
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -362,7 +362,6 @@ public long timeToNextUpdate(long requestTimeoutMs) {
throw new IllegalStateException("Unknown telemetry state:
" + localState);
}
- log.debug("For telemetry state {}, returning the value {} ms; {}",
localState, timeMs, msg);
Review Comment:
I think emitting metrics would have been helpful if we want to derive some
meaningful information about the running reporter, but here the log was helpful
to see if reporter is working correctly while testing/debugging. Rather than
removing it, I moved it to trace so still there is a way to know what's the
state of reporter if we need to debug application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
