philipnee commented on code in PR #15148:
URL: https://github.com/apache/kafka/pull/15148#discussion_r1453824378
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -715,15 +716,22 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
}
CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes());
- ByteBuffer buffer = ClientTelemetryUtils.compress(payload,
compressionType);
+ byte[] compressedPayload;
+ try {
+ compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
+ } catch (IOException e) {
+ log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
thanks Apoorv, i'm ok with info level logging - wdyt @mjsax?
i mentioned logging error to debug because it seems like the caught
exception is not being logged anywhere - i was wondering if we should at least
somewhat log that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
