mjsax commented on code in PR #15148:
URL: https://github.com/apache/kafka/pull/15148#discussion_r1451046445
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -715,15 +716,22 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
}
CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes());
- ByteBuffer buffer = ClientTelemetryUtils.compress(payload,
compressionType);
+ byte[] compressedPayload;
+ try {
+ compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
+ } catch (IOException e) {
+ log.info("Failed to compress telemetry payload for
compression: {}, sending uncompressed data", compressionType);
Review Comment:
Should this be WARN-level (or maybe even ERROR) -- Do we have existing
similar cases elsewhere in client for which we fall back to uncompressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
