ableegoldman commented on code in PR #15162:
URL: https://github.com/apache/kafka/pull/15162#discussion_r1452787287
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1111,28 +1111,31 @@ <h4><a class="toc-backref" href="#id18">Default
Values</a><a class="headerlink"
<td>Consumer</td>
<td>earliest</td>
</tr>
- <tr class="row-even"><td>linger.ms</td>
+ <tr class="row-odd"><td>linger.ms</td>
<td>Producer</td>
<td>100</td>
</tr>
<tr class="row-even"><td>max.poll.records</td>
<td>Consumer</td>
<td>1000</td>
</tr>
+ <tr class="row-odd">
+ <td>transaction.timeout.ms</td>
+ <td>Producer</td>
+ <td><code class="docutils literal"><span
class="pre">10000</span></code></td>
+ </tr>
+ <tr class="row-even">
+ <td>client.id</td>
+ <td>-</td>
+ <td><code class="docutils literal"><span
class="pre"><application.id>-<random-UUID></span></code></td>
Review Comment:
People do ask about the `cliend.id` fairly often, so imho it's a common
enough source of confusion that it's worth laying out in the docs, even if it's
a bit complicated. Maybe it doesn't all fit well into this table but perhaps
you can add a short section about the `client.id` somewhere above/below this
table, and then for the "default" value just write "See here for details" with
a link to that section...something like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
