mjsax commented on code in PR #15162:
URL: https://github.com/apache/kafka/pull/15162#discussion_r1451029920
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -409,12 +409,12 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
<td>Medium</td>
<td colspan="2">The replication factor for changelog topics and
repartition topics created by the application.
The default of <code>-1</code> (meaning: use broker default
replication factor) requires broker version 2.4 or newer.</td>
- <td>-1</td>
+ <td><code class="docutils literal"><span
class="pre">-1</span></code></td>
</tr>
<tr class="row-even"><td>retry.backoff.ms</td>
- <td>Medium</td>
- <td colspan="2">The amount of time in milliseconds, before a
request is retried. This applies if the <code class="docutils literal"><span
class="pre">retries</span></code> parameter is configured to be greater than 0.
</td>
- <td>100 milliseconds</td>
+ <td>Medium</td>
+ <td colspan="2">The amount of time in milliseconds, before a
request is retried. This applies if the <code class="docutils literal"><span
class="pre">retries</span></code> parameter is configured to be greater than 0.
</td>
+ <td>100 milliseconds</td>
Review Comment:
```suggestion
<td><code class="docutils literal"><span
class="pre">100</span></code></td>
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1111,28 +1111,31 @@ <h4><a class="toc-backref" href="#id18">Default
Values</a><a class="headerlink"
<td>Consumer</td>
<td>earliest</td>
</tr>
- <tr class="row-even"><td>linger.ms</td>
+ <tr class="row-odd"><td>linger.ms</td>
<td>Producer</td>
<td>100</td>
</tr>
<tr class="row-even"><td>max.poll.records</td>
<td>Consumer</td>
<td>1000</td>
</tr>
+ <tr class="row-odd">
+ <td>transaction.timeout.ms</td>
+ <td>Producer</td>
+ <td><code class="docutils literal"><span
class="pre">10000</span></code></td>
+ </tr>
+ <tr class="row-even">
+ <td>client.id</td>
+ <td>-</td>
+ <td><code class="docutils literal"><span
class="pre"><application.id>-<random-UUID></span></code></td>
Review Comment:
That not correct. And it's more complicated overall...
By default, ie, if `client.id` is not provided by the user, we set an
internal `clientId = applicationId + "-" + processId` (with processId being a
UUID), ie, what you describe.
However, for different clients (consumer/producer/admin) we generate more
complex ones:
- main consumer (`client.id` per thread):
`clientId + "-StreamThread-" + threadIdx + "-consumer"`
- restore consumer (`client.id` per thread):
`clientId + "-StreamThread-" + threadIdx + "-restore-consumer"`
- global consumer:
`clientId + "-global-consumer"`
- producer (alos + eos-beta; `client.id` per thread):
`clientId + "-StreamThread-" + threadIdx + "-producer"`
- producer (eos-alpha; `client.id` per task):
`clientId + "-StreamThread-" + threadIdx + "-" + taskId + "-producer"`
- admin:
`clientId + "-admin"`
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -409,12 +409,12 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
<td>Medium</td>
<td colspan="2">The replication factor for changelog topics and
repartition topics created by the application.
The default of <code>-1</code> (meaning: use broker default
replication factor) requires broker version 2.4 or newer.</td>
- <td>-1</td>
+ <td><code class="docutils literal"><span
class="pre">-1</span></code></td>
</tr>
<tr class="row-even"><td>retry.backoff.ms</td>
- <td>Medium</td>
- <td colspan="2">The amount of time in milliseconds, before a
request is retried. This applies if the <code class="docutils literal"><span
class="pre">retries</span></code> parameter is configured to be greater than 0.
</td>
- <td>100 milliseconds</td>
+ <td>Medium</td>
+ <td colspan="2">The amount of time in milliseconds, before a
request is retried. This applies if the <code class="docutils literal"><span
class="pre">retries</span></code> parameter is configured to be greater than 0.
</td>
+ <td>100 milliseconds</td>
Review Comment:
The description already say:
> The amount of time in milliseconds
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1111,28 +1111,31 @@ <h4><a class="toc-backref" href="#id18">Default
Values</a><a class="headerlink"
<td>Consumer</td>
Review Comment:
Just saw the following above:
```
For detailed descriptions
of these configs, see <a class="reference external"
href="http://kafka.apache.org/0100/documentation.html#producerconfigs";>Producer
Configs</a>
and <a class="reference external"
href="http://kafka.apache.org/0100/documentation.html#newconsumerconfigs";>Consumer
Configs</a>.</p>
```
Still links to 0.10.0... Can we fix it?
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1111,28 +1111,31 @@ <h4><a class="toc-backref" href="#id18">Default
Values</a><a class="headerlink"
<td>Consumer</td>
<td>earliest</td>
</tr>
- <tr class="row-even"><td>linger.ms</td>
+ <tr class="row-odd"><td>linger.ms</td>
<td>Producer</td>
<td>100</td>
</tr>
<tr class="row-even"><td>max.poll.records</td>
<td>Consumer</td>
<td>1000</td>
</tr>
+ <tr class="row-odd">
+ <td>transaction.timeout.ms</td>
Review Comment:
We set this only if EOS is enabled. Might be worth to call out?
We also set `delivery.timeout.ms` to "max integer" and enable idempotency if
EOS is enabled.
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1111,28 +1111,31 @@ <h4><a class="toc-backref" href="#id18">Default
Values</a><a class="headerlink"
<td>Consumer</td>
<td>earliest</td>
</tr>
- <tr class="row-even"><td>linger.ms</td>
+ <tr class="row-odd"><td>linger.ms</td>
<td>Producer</td>
<td>100</td>
</tr>
<tr class="row-even"><td>max.poll.records</td>
<td>Consumer</td>
<td>1000</td>
</tr>
+ <tr class="row-odd">
+ <td>transaction.timeout.ms</td>
+ <td>Producer</td>
+ <td><code class="docutils literal"><span
class="pre">10000</span></code></td>
+ </tr>
+ <tr class="row-even">
+ <td>client.id</td>
+ <td>-</td>
+ <td><code class="docutils literal"><span
class="pre"><application.id>-<random-UUID></span></code></td>
+ </tr>
</tbody>
</table>
</div>
<div class="section" id="parameters-controlled-by-kafka-streams">
<h3><a class="toc-backref" href="#id26">Parameters controlled by Kafka
Streams</a><a class="headerlink" href="#parameters-controlled-by-kafka-streams"
title="Permalink to this headline"></a></h3>
- <p>Kafka Streams assigns the following configuration parameters. If you
try to change
- <code class="docutils literal"><span
class="pre">allow.auto.create.topics</span></code>, your value
- is ignored and setting it has no effect in a Kafka Streams
application. You can set the other parameters.
- Kafka Streams sets them to different default values than a plain
- <code class="docutils literal"><span
class="pre">KafkaConsumer</span></code>.
- <p>Kafka Streams uses the <code class="docutils literal"><span
class="pre">client.id</span></code>
- parameter to compute derived client IDs for internal clients. If you
don't set
- <code class="docutils literal"><span
class="pre">client.id</span></code>, Kafka Streams sets it to
- <code class="docutils literal"><span
class="pre"><application.id>-<random-UUID></span></code>.
+ <p>Some parameters are not configurable by the user. If you supply a
value that is different from the default value,
+ your value is ignored. Below is a list of some of these parameters.
Review Comment:
We also set consumer `isolation.level` to `READ_COMMITTED` if EOS is enabled.
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1111,28 +1111,31 @@ <h4><a class="toc-backref" href="#id18">Default
Values</a><a class="headerlink"
<td>Consumer</td>
Review Comment:
We also set `max.poll.records` to 1000.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
