lucasbru commented on PR #15000:
URL: https://github.com/apache/kafka/pull/15000#issuecomment-1885169869
In terms of implementation of the autocommit-interceptor in the application
thread, I see three options:
- Move auto-commit triggering to application thread. That seems cleanest to
me (all commits are triggered from the application thread), but it's the
largest refactoring. Then the interceptor is trivial.
- Share the Invoker queue with the background thread, and access it when we
register the auto-commit callback. It's already shared with the background
thread implicitly as part of the commitrequest completed future.
- Add a new background event in the background event queue. Seems unclean,
since we already have a common datastructure shared between application &
background thread for things to be invoked after a commit, and that is the
"Invoker" (option 2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
