lucasbru commented on PR #15000:
URL: https://github.com/apache/kafka/pull/15000#issuecomment-1877184050
@philipnee Good point about auto-commits, I missed that. It's a pity that
auto-commits aren't triggered from the main thread (I wonder if we could do
that? Would be another architectural change).
I would go for solution num 1 because
- Original KIP clearly states that it should only call into the interceptor
from a single thread, so I think we'd easily break code if we start requiring
them to be thread-safe. Yeah, you could write a KIP, but not sure if that's
reasonable here.
- When would we not trigger the interceptor in this case? If you are
talking about `Consumer.close()`, could we make sure to empty the background
event queue after closing the background thread, and then run the invoker?
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
