hutiefang76 opened a new pull request, #4364:
URL: https://github.com/apache/streampark/pull/4364
## What changes were proposed in this pull request
Issue Number: close #4157
This pull request updates `FlinkVersion.checkVersion` to parse the numeric
prefix of each version segment. This keeps normal Apache Flink versions
unchanged while allowing vendor-suffixed patch versions such as `1.19.1-amzn-1`
to be checked without throwing `NumberFormatException`.
## Brief change log
- Parse numeric version segment prefixes in `FlinkVersion` before matching
supported Flink versions.
- Add unit tests for vendor-suffixed Flink versions in both `checkVersion()`
and `checkVersion(sinceVersion)` paths.
## Verifying this change
This change added tests and can be verified as follows:
- Added `FlinkVersionTest` to verify `1.19.1-amzn-1` is accepted and
unsupported vendor-suffixed versions are rejected without throwing.
- Ran locally:
```bash
JAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -s
/tmp/codex-empty-maven-settings.xml -pl streampark-common -DskipITs -DskipRat
-DfailIfNoTests=false -Dtest=FlinkVersionTest test
```
Result: `Tests run: 3, Failures: 0, Errors: 0, Skipped: 0`.
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
