hutiefang76 opened a new pull request, #4363:
URL: https://github.com/apache/streampark/pull/4363

   ## What changed
   
   This fixes the alert email connection check for SSL SMTP settings.
   
   The actual email sending path uses SSL-on-connect when `SenderEmail.ssl` is 
enabled, but `SettingServiceImpl.checkEmail` was enabling STARTTLS instead. 
That makes the check fail for SSL SMTP servers such as the case reported in 
#4072.
   
   This patch extracts the JavaMail property building and makes `checkEmail` 
set `mail.smtp.ssl.enable=true` when SSL is selected. Plain SMTP keeps the 
existing behavior.
   
   ## Tests
   
   ```bash
   JAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -s 
/tmp/codex-empty-maven-settings.xml \
     -pl streampark-console/streampark-console-service -am \
     -DskipITs -DskipRat -DskipWeb -DfailIfNoTests=false \
     -Dtest=SettingServiceImplTest test
   ```
   
   Also checked:
   
   ```bash
   git diff --check
   ```
   
   I used OpenAI Codex to help inspect the issue and prepare the patch, then 
reviewed the diff and ran the tests above locally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to