ilariapet commented on code in PR #3705:
URL: https://github.com/apache/solr/pull/3705#discussion_r2401529198
##########
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##########
@@ -88,6 +94,17 @@ public EarlyTerminationParams getEarlyTerminationParams() {
return new EarlyTerminationParams(enabled, saturationThreshold, patience);
}
+ protected Query getSeedQuery() throws SolrException, SyntaxError {
+ String seed = localParams.get(SEED);
+ if (seed == null) return null;
+ if (seed.isBlank()) {
+ log.warn("Seed query is blank, defaulting to null");
+ return null;
Review Comment:
Thank you very much @cpoerschke for your draft PR, which inspired me, and
for your review. I was also uncertain about whether to throw the exception or
leave it less restrictive, but I agree with you that it’s better to throw the
exception.
##########
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##########
@@ -88,6 +94,17 @@ public EarlyTerminationParams getEarlyTerminationParams() {
return new EarlyTerminationParams(enabled, saturationThreshold, patience);
}
+ protected Query getSeedQuery() throws SolrException, SyntaxError {
+ String seed = localParams.get(SEED);
+ if (seed == null) return null;
+ if (seed.isBlank()) {
+ log.warn("Seed query is blank, defaulting to null");
+ return null;
Review Comment:
Thank you very much @cpoerschke for your draft PR, which inspired me, and
for your review. I was also uncertain about whether to throw the exception or
leave it less "restrictive", but I agree with you that it’s better to throw the
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
