ilariapet opened a new pull request, #3705: URL: https://github.com/apache/solr/pull/3705
https://issues.apache.org/jira/browse/SOLR-17813 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Apache Lucene implemented a version of knn vector query called SeededKnnVectorQuery that provides a query seed to initiate the vector search (entry points in the HNSW graph exploration) based on [Lexically-Accelerated Dense Retrieval](https://arxiv.org/pdf/2307.16779) # Solution This PR introduces a new optional parameter for the current KNN query parser: `seed`. The seed parameter can be any valid Solr query, allowing traditional query logic to guide the vector search in a hybrid-like fashion. Added a new method `getSeedQuery()` that parses the seed parameter and returns the corresponding Lucene Query. When a seed query is present, the KNN vector query is wrapped with SeededKnnVectorQuery: - SeededKnnVectorQuery.fromFloatQuery(...) for FLOAT32 vectors. - SeededKnnVectorQuery.fromByteQuery(...) for BYTE vectors. If no seed is provided, the parser behaves as before and executes a "standard" KNN query. Currently seed and earlyTermination parameters cannot be used together due to Lucene Issue [#14688](https://github.com/apache/lucene/pull/14688). Solr must be upgraded to a Lucene version that includes this patch. # Tests - Test to verify that when the seed parameter is provided, the SeededKnnVectorQuery is executed (both float and byte). - Test to verify that when the seed parameter is provided but blank, it is treated as null, and no additional seed logic is applied. - Test to verify that when the seed parameter is provided with an invalid value, Solr throws a BAD_REQUEST exception. - Test to verify that when both seed and early termination parameters are provided, Solr throws a BAD_REQUEST exception. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
