jiayuasu commented on PR #2922:
URL: https://github.com/apache/sedona/pull/2922#issuecomment-4394795828
Addressed in 1339c4bb1f:
- L34 (announcement banner relative URL): wrapped with `| url` filter.
- L4/28/42/777 (`lang` recomputed in 4 blocks): hoisted to a single
top-level `set` and renamed to `cur_lang` to avoid the name collision with
mkdocs-material's `lang` (which `base.html` imports as a TemplateModule from
`partials/language.html`). Folded `events_decor` into the main `i18n` dict.
- L95 ("distribute cluster" → "distributed cluster"): fixed.
Skipped (pre-existing patterns, not introduced by this PR):
- L307/L335 (`/sedonadb` absolute links): these point to a sister site at
`https://sedona.apache.org/sedonadb/`, not into the current docs tree (see
`mkdocs.yml` nav: `SedonaDB: 'https://sedona.apache.org/sedonadb/'`). The
root-absolute path is intentional and works on production.
- `download.zh.md` table `| |` syntax: preserved verbatim from the English
`download.md` to keep the structure aligned. mkdocs-material renders it
correctly.
- `sedonaflink.zh.md` Java snippet missing semicolons: same code exists
identically in the English `sedonaflink.md`. Fixing would require a separate PR
that updates both locales (and arguably the original landing copy).
`outdated_msg` and `announcement` were left scoped to their respective
blocks since each is referenced exactly once and locality reads more clearly
than a giant top-level dict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
