jiayuasu commented on code in PR #2801:
URL: https://github.com/apache/sedona/pull/2801#discussion_r3007739517
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/BroadcastIndexJoinExec.scala:
##########
@@ -118,6 +118,7 @@ case class BroadcastIndexJoinExec(
case (Some(r), _, false) => s"ST_Distance($windowExpression,
$objectExpression) < $r"
case (None, _, false) => s"ST_$spatialPredicate($windowExpression,
$objectExpression)"
case (None, _, true) => s"RS_$spatialPredicate($windowExpression,
$objectExpression)"
+ case (Some(r), _, true) => s"RS_$spatialPredicate($windowExpression,
$objectExpression)"
}
Review Comment:
Replaced with `throw new UnsupportedOperationException`. Raster + distance
is not supported because `createStreamShapes` always uses
`GeometrySerializer.deserialize` when distance is defined — raster bytes would
cause a deserialization failure.
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/JoinQueryDetector.scala:
##########
@@ -786,6 +786,9 @@ class JoinQueryDetector(sparkSession: SparkSession) extends
SparkStrategy {
case (Some(_), _, true, _, false) => "ST_Distance (Geography) <"
case (None, _, false, _, false) => s"ST_$spatialPredicate"
case (None, _, false, _, true) => s"RS_$spatialPredicate"
+ case (None, _, true, _, false) => s"ST_$spatialPredicate (Geography)"
+ case (None, _, true, _, true) => s"RS_$spatialPredicate"
+ case (Some(_), _, _, _, true) => s"RS_$spatialPredicate"
}
Review Comment:
All three new cases now throw `UnsupportedOperationException`: raster +
distance (not implemented), geography + non-raster (not yet supported),
geography + raster (not yet supported).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
