jiayuasu commented on code in PR #2801:
URL: https://github.com/apache/sedona/pull/2801#discussion_r3006866506
##########
common/src/test/java/org/apache/sedona/common/S2Geography/TestHelper.java:
##########
@@ -172,8 +176,8 @@ public static void checkWKBGeography(String wkbHex, String
expectedWKT) throws P
boolean isEqual = compareTo(geoWKT, geoWKT) == 0;
Review Comment:
Fixed. Changed `compareTo(geoWKT, geoWKT)` to `compareTo(geoWKB, geoWKT)`.
##########
spark/common/src/main/scala/org/apache/sedona/viz/showcase/ScalaExample.scala:
##########
@@ -96,16 +97,15 @@ object ScalaExample extends App {
val HDFDataVariableList = Array("LST", "QC", "Error_LST", "Emis_31",
"Emis_32")
val HDFswitchXY = true
val urlPrefix = System.getProperty("user.dir") +
"/../spark/common/src/test/resources/modis/"
- var ConfFile = new FileInputStream(resourcePath + "babylon.point.properties")
if (buildScatterPlot(scatterPlotOutputPath) &&
buildHeatMap(heatMapOutputPath)
&& buildChoroplethMap(choroplethMapOutputPath) &&
parallelFilterRenderStitch(
parallelFilterRenderStitchOutputPath + "-stitched")
&& parallelFilterRenderNoStitch(
parallelFilterRenderStitchOutputPath) && earthdataVisualization(
earthdataScatterPlotOutputPath))
- System.out.println("All 5 Demos have passed.")
- else System.out.println("Demos failed.")
+ println("All 5 Demos have passed.")
+ else println("Demos failed.")
Review Comment:
These are showcase/example files, not library code. `println` in Scala is
idiomatic for examples. Leaving as-is.
##########
spark/common/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala:
##########
@@ -73,7 +73,7 @@ object ScalaExample extends App {
testDistanceJoinQuery()
testDistanceJoinQueryUsingIndex()
sc.stop()
- System.out.println("All DEMOs passed!")
+ println("All DEMOs passed!")
Review Comment:
Same as above — showcase code, `println` is fine here.
##########
spark/common/src/main/scala/org/apache/sedona/core/showcase/ScalaEarthdataMapperRunnableExample.scala:
##########
@@ -47,7 +47,7 @@ object ScalaEarthdataMapperRunnableExample extends App {
testSpatialRangeQuery()
testSpatialRangeQueryUsingIndex()
sc.stop()
- System.out.println("All Earthdata DEMOs passed!")
+ println("All Earthdata DEMOs passed!")
Review Comment:
Same as above — showcase code, `println` is fine here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
