petern48 commented on code in PR #2042:
URL: https://github.com/apache/sedona/pull/2042#discussion_r2202050203
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -463,10 +463,21 @@ def test_get_geometry(self):
pass
def test_boundary(self):
- pass
+ for _, geom in self.geoms:
+ # Shapely < 2.0 doesn't support GeometryCollection for boundary
operation
+ if shapely.__version__ < "2.0.0" and isinstance(
Review Comment:
I'd rather update all comparisons to parse() all at once in a separate PR,
so I don't risk more merge conflicts (really just from the import) and cycles
between code reviews. For this number specifically (2.0.0), it should be safe
to do string comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
