Copilot commented on code in PR #2042:
URL: https://github.com/apache/sedona/pull/2042#discussion_r2202031107
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -463,10 +463,21 @@ def test_get_geometry(self):
pass
def test_boundary(self):
- pass
+ for _, geom in self.geoms:
+ # Shapely < 2.0 doesn't support GeometryCollection for boundary
operation
+ if shapely.__version__ < "2.0.0" and isinstance(
Review Comment:
[nitpick] Comparing version strings lexically can be brittle for multi-part
version numbers. Consider using `packaging.version.parse(shapely.__version__)`
(or similar) to ensure accurate semantic version comparisons.
```suggestion
if parse(shapely.__version__) < parse("2.0.0") and isinstance(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
