Kontinuation opened a new pull request, #2054:
URL: https://github.com/apache/sedona/pull/2054

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor 
Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   
   As discussed in 
https://github.com/apache/sedona/issues/1996#issuecomment-2995332894, we have 
switched s2 dependency to our own `org.datasyslab:s2-geometry-library`. This 
may cause conflicts if there's `com.google.geometry:s2-geometry` packages in 
the runtime environment. We decided to shade it into sedona-common to get rid 
of possible conflicts.
   
   `org.datasyslab:s2-geometry-library` depends on a recent version of Guava, 
which is incompatible with the Guava jar shipped with Apache Spark, so we have 
to shade guava into sedona-common as well.
   
   We have also cherry-picked 
https://github.com/apache/sedona/commit/e005f23c3d7438d55dcfa199f497064d8178924f#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8
 into this PR, this is for fixing problems with shading janino found when 
releasing 1.7.2.
   
   ## How was this patch tested?
   
   * Passing existing tests
   * Manually tested the spark-shaded jar in local environment
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the 
documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to