jiayuasu commented on code in PR #2023:
URL: https://github.com/apache/sedona/pull/2023#discussion_r2181920936
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -298,7 +298,13 @@ def test_clip(self):
pass
def test_geom_type(self):
- pass
+ for _, geom in self.geoms:
+ sgpd_result = GeoSeries(geom).geom_type
+ assert isinstance(sgpd_result, ps.Series)
+ gpd_result = gpd.GeoSeries(geom).geom_type
+ # Geopandas doesn't return the strings in all caps like sedona does
Review Comment:
can we make the output produce the same result for this specific function?
Maybe just use a simple match inside this `geom_type` function to hard code
the output to be the same as geopandas...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
