[
https://issues.apache.org/jira/browse/RATIS-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066395#comment-18066395
]
Tsz-wo Sze commented on RATIS-2338:
-----------------------------------
{quote}... we cannot simply rename the {{origin}} remote to the official
Apache repo to solve this. ...
{quote}
[~tanxinyu], Sorry that I was not clear – I meant if we clone from Apache and
then build the release. The URL in git will be the Apache URL.
{code:java}
$git clone https://github.com/apache/ratis.git apache-ratis
$cd apache-ratis
$ ./dev-support/make_rc.sh ...
{code}
{quote}... Override via CLI in make_rc.sh ...
{quote}
For overriding (or hard coding), if we could verify the overriding repo is
indeed correct (i.e. the commit does exist in the repo.) Then, it is a good
approach. Otherwise, if the overriding repo does not contain the commit, it
will be very confusing.
We may consider passing the repo URL as an optional parameter to make_rc.sh.
Then, make_rc.sh will checkout the code to a tmp dir and build from there.
{quote}... simply remove the url field ...
{quote}
The property "url=${version-info.scm.uri}" may not be very useful today since
all the Ratis releases were from Apache repo. It becomes useful if there are
releases from different repos. So, we may consider removing it now and adding
it back in the future.
[~adoroszlai], what to you think?
> Print version info when starting a server
> -----------------------------------------
>
> Key: RATIS-2338
> URL: https://issues.apache.org/jira/browse/RATIS-2338
> Project: Ratis
> Issue Type: Improvement
> Components: server
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Fix For: 3.2.1
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We are already using hadoops:version-info to generate
> ratis-version.properties files. This JIRA is to print the version info when
> starting a server.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
