[ 
https://issues.apache.org/jira/browse/RATIS-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066162#comment-18066162
 ] 

Tsz-wo Sze commented on RATIS-2338:
-----------------------------------

> ... I think we could mitigate the problem by pointing the remote origin to 
> apache/ratis, ...

[~adoroszlai], the reproducible issue was caused by adding 
"url=${version-info.scm.uri}" to 
[src/main/resources/ratis-version.properties|https://github.com/apache/ratis/blob/ad1456ecad4711fde0e033f91a9450646c51d5f1/src/main/resources/ratis-version.properties#L20],
 while Ozone also had it in 
[hadoop-hdds/common/src/main/resources/hdds-version-info.properties|https://github.com/apache/ozone/blob/102b51a319c3ea72c19fe5026630fb41ed2c4af0/hadoop-hdds/common/src/main/resources/hdds-version-info.properties#L21].
 I checked the generated hdds-version-info.properties file in the Ozone 2.1.0 
release. It used the Apache URL.

So I agree that we should roll releases from Apache repo.

BTW, is there a way to test reproducible? If yes, we should do it as a part of 
verifying a release candidate.
----
FYI, the repo URL obtained by hadoops:version-info is just from .git/config.
 - .git/config (modified the URL arbitrary)
{code:java}
[remote "origin"]
        url = https://[email protected]/apache/ratis_testing.git
{code}

 - ratis-server/target/classes/ratis-version.properties
{code:java}
name=Apache Ratis Server
version=3.3.0-SNAPSHOT
url=https://[email protected]/apache/ratis_testing.git
revision=ad1456ecad4711fde0e033f91a9450646c51d5f1
{code}

> Print version info when starting a server
> -----------------------------------------
>
>                 Key: RATIS-2338
>                 URL: https://issues.apache.org/jira/browse/RATIS-2338
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>             Fix For: 3.2.1
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> We are already using hadoops:version-info to generate 
> ratis-version.properties files.  This JIRA is to print the version info when 
> starting a server.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to