adutra commented on code in PR #3750:
URL: https://github.com/apache/polaris/pull/3750#discussion_r2890601076
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -246,13 +244,9 @@ public Response updateProperties(
}
private EnumSet<AccessDelegationMode> parseAccessDelegationModes(String
accessDelegationMode) {
- EnumSet<AccessDelegationMode> delegationModes =
- AccessDelegationMode.fromProtocolValuesList(accessDelegationMode);
- Preconditions.checkArgument(
- delegationModes.isEmpty() ||
delegationModes.contains(VENDED_CREDENTIALS),
Review Comment:
Indeed I think that if the set contains only `UNKNOWN` we should throw some
error, probably here.
As for removing the `UNKNOWN` entry from the set, this is already being done
in `DefaultAccessDelegationModeResolver` from what I see, so I don't think we
need to remove it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
