dimas-b commented on code in PR #3750:
URL: https://github.com/apache/polaris/pull/3750#discussion_r2890522832
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -246,13 +244,9 @@ public Response updateProperties(
}
private EnumSet<AccessDelegationMode> parseAccessDelegationModes(String
accessDelegationMode) {
- EnumSet<AccessDelegationMode> delegationModes =
- AccessDelegationMode.fromProtocolValuesList(accessDelegationMode);
- Preconditions.checkArgument(
- delegationModes.isEmpty() ||
delegationModes.contains(VENDED_CREDENTIALS),
Review Comment:
It looks like if `accessDelegationMode` contains only invalid values
(represented by `UNKNOWN`) we used to fail the request before, but now the
`UNKNOWN` delegation mode is carried forward (and will eventually be accepted).
I believe we have to keep old behaviour where requests with invalid access
modes failed.
If a request contains some invalid access modes (`UNKNOWN`) and some value,
I tend to think we can remove the `UNKNOWN` entry from the `EnumSet` here and
carry on.
@adutra WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
