obelix74 commented on code in PR #3385:
URL: https://github.com/apache/polaris/pull/3385#discussion_r2850894181


##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########


Review Comment:
   We have a problem with this approach. If the main schema moves forward and 
this file stays, then metrics version will overwrite the main version.
   
   We can either create a separete metrics version or don't update version if 
it's higher (use WHERE version_value < EXCLUDED.version_value).
   
   What would you prefer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to