flyrain commented on code in PR #3385:
URL: https://github.com/apache/polaris/pull/3385#discussion_r2850547708
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
Review Comment:
I think this will create the metrics table in the data source that is not
supposed to hold the metrics table. I think we still need two schema files if
two different data sources are supported. So that metrics data source will
execute the init script for the metrics table.
And we will need the version table in both data source, otherwise, there is
no way to tell which schema version it is when the metrics table is in a
separate postgres schema or database.
```
INSERT INTO version (version_key, version_value)
VALUES ('version', 4)
ON CONFLICT (version_key) DO UPDATE
SET version_value = EXCLUDED.version_value;
COMMENT ON TABLE version IS 'the version of the JDBC schema in use';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
