obelix74 commented on code in PR #3823: URL: https://github.com/apache/polaris/pull/3823#discussion_r2834913777
########## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/SessionTagField.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.storage.aws; + +import java.util.Optional; +import org.apache.polaris.core.storage.CredentialVendingContext; +import software.amazon.awssdk.services.sts.model.Tag; + +/** + * Enum representing the supported fields that can be included as AWS STS session tags in credential + * vending. Each value knows its tag key and how to extract its value from a {@link + * CredentialVendingContext}. + * + * <p>These tags appear in CloudTrail events for correlation between catalog operations and S3 data + * access. Configure via {@code SESSION_TAGS_IN_SUBSCOPED_CREDENTIAL} using the {@link #configName} + * of each desired field. + */ +public enum SessionTagField { + REALM("realm", CredentialVendingContext.TAG_KEY_REALM) { + @Override + public Optional<Tag> buildTag(String principalName, CredentialVendingContext context) { + return Optional.of(tag(context.realm().orElse(AwsSessionTagsBuilder.TAG_VALUE_UNKNOWN))); + } + }, + CATALOG("catalog", CredentialVendingContext.TAG_KEY_CATALOG) { + @Override + public Optional<Tag> buildTag(String principalName, CredentialVendingContext context) { + return Optional.of( + tag(context.catalogName().orElse(AwsSessionTagsBuilder.TAG_VALUE_UNKNOWN))); + } + }, + NAMESPACE("namespace", CredentialVendingContext.TAG_KEY_NAMESPACE) { + @Override + public Optional<Tag> buildTag(String principalName, CredentialVendingContext context) { + return Optional.of(tag(context.namespace().orElse(AwsSessionTagsBuilder.TAG_VALUE_UNKNOWN))); + } + }, + TABLE("table", CredentialVendingContext.TAG_KEY_TABLE) { + @Override + public Optional<Tag> buildTag(String principalName, CredentialVendingContext context) { + return Optional.of(tag(context.tableName().orElse(AwsSessionTagsBuilder.TAG_VALUE_UNKNOWN))); + } + }, Review Comment: I think the views would use the existing table tag field since tableName in CredentialVendingContext can hold either a table or view name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
