dimas-b commented on code in PR #3823:
URL: https://github.com/apache/polaris/pull/3823#discussion_r2824813551
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/StorageAccessConfigProvider.java:
##########
@@ -189,16 +201,10 @@ private CredentialVendingContext
buildCredentialVendingContext(
builder.activatedRoles(Optional.of(rolesString));
}
- // Only include trace ID when the feature flag is enabled.
- // When enabled, trace IDs are included in AWS STS session tags and become
part of the
- // credential cache key (since they affect the vended credentials).
- // When disabled (default), trace IDs are not included, allowing efficient
credential
- // caching across requests with different trace IDs.
- boolean includeTraceIdInSessionTags =
- storageCredentialsVendor
- .getRealmConfig()
- .getConfig(FeatureConfiguration.INCLUDE_TRACE_ID_IN_SESSION_TAGS);
- if (includeTraceIdInSessionTags) {
+ // Only include trace ID when "trace_id" is in the configured session tag
fields.
+ // When included, trace IDs become part of the credential cache key (since
they affect
+ // the vended credentials), which disables effective credential caching.
+ if (sessionTagFields.contains("trace_id")) {
Review Comment:
Let's introduce a constant for `trace_id`... Maybe parallel to
`SUPPORTED_SESSION_TAG_FIELDS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
