flyrain commented on code in PR #3385: URL: https://github.com/apache/polaris/pull/3385#discussion_r2830981755
########## persistence/relational-jdbc/src/main/resources/postgres/schema-metrics-v1.sql: ########## Review Comment: Not related to this PR, but I think having a catalog name and table identifier(`namespace.table`) would benefit the metrics query so that no join is needed. It could be especially useful when metrics and Polaris entity are in different data source or even different type of database, Prometheus vs Postgres. Not a blocker for this PR though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
