obelix74 commented on code in PR #3385:
URL: https://github.com/apache/polaris/pull/3385#discussion_r2820125798
##########
persistence/relational-jdbc/build.gradle.kts:
##########
@@ -29,10 +29,16 @@ dependencies {
compileOnly(platform(libs.jackson.bom))
compileOnly("com.fasterxml.jackson.core:jackson-annotations")
+ compileOnly("com.fasterxml.jackson.core:jackson-databind")
compileOnly(libs.jakarta.annotation.api)
compileOnly(libs.jakarta.enterprise.cdi.api)
compileOnly(libs.jakarta.inject.api)
+ // Iceberg API for metrics report conversion
+ compileOnly(platform(libs.iceberg.bom))
+ compileOnly("org.apache.iceberg:iceberg-api")
+ compileOnly("org.apache.iceberg:iceberg-core")
Review Comment:
Upon investigation, these iceberg compileOnly dependencies weren't actually
used - the SpiModelConverter converts between polaris-core SPI types and JDBC
model types, not Iceberg types directly. The tests already have
testImplementation for iceberg-api. Removed the unused dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
