dimas-b commented on code in PR #3755:
URL: https://github.com/apache/polaris/pull/3755#discussion_r2818073306
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -71,12 +72,12 @@ private static void
registerConfiguration(PolarisConfiguration<?> configuration)
}
}
}
- allConfigurations.add(configuration);
+ ALL_CONFIGURATIONS.add(configuration);
}
/** Returns a list of all PolarisConfigurations that have been registered */
public static List<PolarisConfiguration<?>> getAllConfigurations() {
- return List.copyOf(allConfigurations);
+ return List.copyOf(ALL_CONFIGURATIONS);
Review Comment:
I'm fine with simple `synchronized` methods. The affected code is not on the
hot path, AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
