adutra commented on code in PR #3755:
URL: https://github.com/apache/polaris/pull/3755#discussion_r2803761221
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -50,7 +52,7 @@ public abstract class PolarisConfiguration<T> {
* configs.
*/
private static void registerConfiguration(PolarisConfiguration<?>
configuration) {
- for (PolarisConfiguration<?> existingConfiguration : allConfigurations) {
+ for (PolarisConfiguration<?> existingConfiguration : ALL_CONFIGURATIONS) {
if (existingConfiguration.key.equals(configuration.key)) {
throw new IllegalArgumentException(
String.format("Config '%s' is already in use", configuration.key));
Review Comment:
Hmm that's right. We might just as well make this method synchronized. I
wanted to avoid that because it's less future-proof than using
`CopyOnWriteArrayList`, but 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
