cccs-cat001 commented on code in PR #3170:
URL: https://github.com/apache/polaris/pull/3170#discussion_r2569451627


##########
.gitignore:
##########
@@ -105,4 +105,5 @@ hs_err_pid*
 .vscode/
 
 # Python Virtual Env
-.venv
\ No newline at end of file
+.venv
+venv

Review Comment:
   I disagree. Some people (including myself) use venv instead of .venv and 
it's a good QOL addition to not have to sift through the venv to find your 
changes. 
   
   That being said, is there any security issues or genuine concerns that arise 
having this `venv` directory ignored?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to