dimas-b commented on code in PR #3170:
URL: https://github.com/apache/polaris/pull/3170#discussion_r2566602739
##########
client/python/apache_polaris/cli/command/catalogs.py:
##########
@@ -76,6 +76,7 @@ class CatalogsCommand(Command):
sts_endpoint: str
sts_unavailable: bool
path_style_access: bool
+ user_token_sts: bool
Review Comment:
nit: Combining CLI changes and backend changes in the same PR is ok, but
these areas usually attract different sets of reviewers. As for me, I usually
do CLI changes in a follow-up PR. Also, I usually do not have material opinions
about CLI code changes :) all in all, it might be easier for reviewers to have
CLI and java changes in different PRs... I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
