eric-maynard commented on code in PR #2361:
URL: https://github.com/apache/polaris/pull/2361#discussion_r2279824310
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##########
@@ -268,14 +271,13 @@ private void dropEntity(
@Nonnull PolarisPrivilege priv) {
// validate non null arguments
- callCtx.getDiagServices().checkNotNull(securable,
"unexpected_null_securable");
- callCtx.getDiagServices().checkNotNull(grantee, "unexpected_null_grantee");
- callCtx.getDiagServices().checkNotNull(priv, "unexpected_null_priv");
+ diagnostics.checkNotNull(securable, "unexpected_null_securable");
Review Comment:
From what I know, `PolarisDiagnostics` is intended to serve as an extensible
way to handle asserts/errors -- so integrators can implement anything from
custom logging to automatically-filed tickets when an issue occurs. To that
end, the mapping between CallContext and PolarisDiagnostics is useful if the
custom logic will be somehow dependent on the caller or the realm.
Having said that, looking at the current usage, I agree that it seems like
`@ApplicationScoped` is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
