dimas-b commented on code in PR #2361:
URL: https://github.com/apache/polaris/pull/2361#discussion_r2279782561
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##########
@@ -268,14 +271,13 @@ private void dropEntity(
@Nonnull PolarisPrivilege priv) {
// validate non null arguments
- callCtx.getDiagServices().checkNotNull(securable,
"unexpected_null_securable");
- callCtx.getDiagServices().checkNotNull(grantee, "unexpected_null_grantee");
- callCtx.getDiagServices().checkNotNull(priv, "unexpected_null_priv");
+ diagnostics.checkNotNull(securable, "unexpected_null_securable");
Review Comment:
This effectively makes `PolarisDiagnostics` realm-scoped at most. In
current Apache Polaris code `PolarisDiagnostics` is actually
`@ApllicationScoped` so this change is fine from my POV.
I wonder what the intended use case for `PolarisDiagnostics` in downstream
projects was initially... @dennishuo @eric-maynard WDYT?
Based on current codebase, from my POV, `PolarisDiagnostics` can remain
`@ApllicationScoped`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
