adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2276616845
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageAccessProperty.java:
##########
@@ -39,6 +42,21 @@ public enum StorageAccessProperty {
Boolean.class, "s3.path-style-access", "whether to use S3 path style
access", false),
CLIENT_REGION(
String.class, "client.region", "region to configure client for making
requests to AWS"),
+ AWS_REMOTE_SIGNING_ENABLED(
+ Boolean.class,
+ S3FileIOProperties.REMOTE_SIGNING_ENABLED,
+ "whether to enable remote signing for S3 requests",
Review Comment:
Actually I don't think that's how it works. Looking at this logic:
https://github.com/apache/polaris/blob/15f23cae8e678f8a13c20c5012919565288525a0/polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java#L116-L142
It seems that remote signing could be _globally_ disabled, but _enabled_ for
a specific catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
