adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2267254496
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java:
##########
@@ -101,6 +110,32 @@ public FileIO loadFileIO(
properties.putAll(accessConfig.get().credentials());
properties.putAll(accessConfig.get().extraProperties());
properties.putAll(accessConfig.get().internalProperties());
+ } else {
+ // If no subscoped creds were produced, use system-wide AWS or GCP
credentials if available.
Review Comment:
This bit is not directly related to remote signing, but I realized that,
when credentials subscoping is disabled, the server is unable to use the
credentials configured in application.properties.
This change allows that.
That being said, the server would still be unable to use e.g. a custom S3
endpoint, simply because this property is not exposed in application.properties.
IMHO each property that can be configured in `AccessConfig` for a specific
catalog should also be configurable by a system-wide property in
application.properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
