XN137 commented on code in PR #2291:
URL: https://github.com/apache/polaris/pull/2291#discussion_r2269816493
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisManagementServiceIntegrationTest.java:
##########
@@ -1743,14 +1745,32 @@ public void
testCatalogAdminGrantAndRevokeCatalogRoles() {
managementApi
.request(
"v1/principal-roles/"
- + principalRoleName
+ + principalRoleName2
+ "/catalog-roles/"
+ catalogName
+ "/"
+ catalogRoleName)
.delete()) {
assertThat(response).returns(Response.Status.NO_CONTENT.getStatusCode(),
Response::getStatus);
}
+
+ // trigger an internal error by using "principalRoleName" instead of
"principalRoleName2"
+ try (Response response =
+ managementApi
+ .request(
+ "v1/principal-roles/"
+ + principalRoleName
+ + "/catalog-roles/"
+ + catalogName
+ + "/"
+ + catalogRoleName)
+ .delete()) {
+ assertThat(response)
+ .returns(Response.Status.INTERNAL_SERVER_ERROR.getStatusCode(),
Response::getStatus);
+ assertThat(response.hasEntity()).isTrue();
+ ErrorResponse errorResponse = response.readEntity(ErrorResponse.class);
+ assertThat(errorResponse.message()).contains("Operation failed:
GRANT_NOT_FOUND");
Review Comment:
ok switched to HTTP/400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
