XN137 commented on code in PR #2291:
URL: https://github.com/apache/polaris/pull/2291#discussion_r2260304308
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -640,7 +661,7 @@ public Response addGrantToCatalogRole(
.log("Don't know how to handle privilege grant: {}", grantRequest);
return Response.status(Response.Status.BAD_REQUEST).build();
}
- return Response.status(Response.Status.CREATED).build();
+ return toResponse(result, Response.Status.CREATED);
Review Comment:
yeah, some methods do throw exceptions internally (and those get propagated
to clients correctly) but the returned `boolean` value of the methods was often
ignored.
as part of this PR we have to fix a test in
`PolarisManagementServiceIntegrationTest.java` which was silently failing
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
