adutra commented on code in PR #2268:
URL: https://github.com/apache/polaris/pull/2268#discussion_r2256740255
##########
build-logic/src/main/kotlin/polaris-runtime.gradle.kts:
##########
@@ -47,6 +54,23 @@ testing {
}
}
+dependencies {
+ // All Quarkus projects should use JBoss LogManager with SLF4J, instead of
Logback
+ implementation("org.jboss.slf4j:slf4j-jboss-logmanager")
+}
Review Comment:
But don't you think this could confuse users?
E.g. some user adds logback-classic to a new Quarkus module, and expects
logging to be configured with logback-test.xml, but instead, the dependency is
silently removed and logging is not configured as expected.
Instead the following block fails hard on that situation:
```kotlin
configurations.all {
// Validate that Logback dependencies are not used in Quarkus modules.
dependencies.configureEach {
if (group == "ch.qos.logback") {
throw GradleException(
"Logback dependencies are not allowed in Quarkus modules. " +
"Found $group:$name in ${project.name}"
)
}
}
}
```
Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
