adutra commented on code in PR #2268:
URL: https://github.com/apache/polaris/pull/2268#discussion_r2256397416
##########
build-logic/src/main/kotlin/polaris-runtime.gradle.kts:
##########
@@ -47,6 +54,23 @@ testing {
}
}
+dependencies {
+ // All Quarkus projects should use JBoss LogManager with SLF4J, instead of
Logback
+ implementation("org.jboss.slf4j:slf4j-jboss-logmanager")
+}
Review Comment:
This would silently remove the dependency. Isn't it better to fail the build?
Re: LICENSE and NOTICE: I checked and logback is not present in any of these
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
