eric-maynard commented on code in PR #2122:
URL: https://github.com/apache/polaris/pull/2122#discussion_r2216898718
##########
plugins/spark/v3.5/spark/src/test/java/org/apache/polaris/spark/rest/DeserializationTest.java:
##########
@@ -82,18 +86,25 @@ public void testLoadGenericTableRESTResponse(String doc,
Map<String, String> pro
assertThat(deserializedResponse.getTable().getName()).isEqualTo("test-table");
assertThat(deserializedResponse.getTable().getDoc()).isEqualTo(doc);
assertThat(deserializedResponse.getTable().getProperties().size()).isEqualTo(properties.size());
+ if (baseLocation != null) {
Review Comment:
Does this assert not work without the `if`?
##########
plugins/spark/v3.5/spark/src/test/java/org/apache/polaris/spark/rest/DeserializationTest.java:
##########
@@ -103,6 +114,11 @@ public void testCreateGenericTableRESTRequest(String doc,
Map<String, String> pr
assertThat(deserializedRequest.getFormat()).isEqualTo("delta");
assertThat(deserializedRequest.getDoc()).isEqualTo(doc);
assertThat(deserializedRequest.getProperties().size()).isEqualTo(properties.size());
+ if (baseLocation != null) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
